Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Incomplete] Add icons for popular podcast services #54556

Closed
wants to merge 3 commits into from
Closed

[Incomplete] Add icons for popular podcast services #54556

wants to merge 3 commits into from

Conversation

properlypurple
Copy link
Contributor

@properlypurple properlypurple commented Sep 18, 2023

What?

This PR aims to add icons for some popular podcast services to the social icons block.

Why?

The social icons block doesn't have icons for some popular podcasting services, and doesn't have a straightforward way to add custom icons. This PR fixes #36755

How?

I aim to add the following icons

  • Apple podcasts
  • Google podcasts
  • Pocketcasts
  • Pandora
  • TuneIn

I have only added Google and Pocketcasts for now. There are significant differences in the brand guidelines for these services, and this will likely need design feedback before going any further. For reference

Testing Instructions

  1. Open a post or page to edit.
  2. Add a social icons block.
  3. Try adding icons for the services mentioned above.
  4. Try changing colors and/or icon style from the block settings.

Testing Instructions for Keyboard

This doesn't change existing interactions for the social icons block, so the usual steps for this block apply.

Screenshots or screencast

image

@github-actions
Copy link

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg.

@properlypurple properlypurple marked this pull request as draft September 18, 2023 13:13
@properlypurple properlypurple closed this by deleting the head repository Oct 9, 2023
@properlypurple
Copy link
Contributor Author

Closing because this is likely going to be redundant with #30749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Link block missing popular podcast services
1 participant