-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Face: Get name from "fontFamily" setting, not "name". #54615
Merged
hellofromtonya
merged 9 commits into
trunk
from
fix/font-face/backup-font-family-name-check
Sep 22, 2023
Merged
Font Face: Get name from "fontFamily" setting, not "name". #54615
hellofromtonya
merged 9 commits into
trunk
from
fix/font-face/backup-font-family-name-check
Sep 22, 2023
Commits on Sep 19, 2023
-
Gets name from fontFamily as fallback check.
If the "name" setting does not exist, then get it from the "fontFamily" setting.
Configuration menu - View commit details
-
Copy full SHA for 5689b53 - Browse repository at this point
Copy the full SHA 5689b53View commit details -
Move tests into existing test.
To avoid reflection issues on different PHP versions and potential contributor confusion, merging the new tests into the existing test.
Configuration menu - View commit details
-
Copy full SHA for 370caf0 - Browse repository at this point
Copy the full SHA 370caf0View commit details -
Do not the "name" settting. Instead only use the required "fontFamily" setting.
Configuration menu - View commit details
-
Copy full SHA for 1c1b96e - Browse repository at this point
Copy the full SHA 1c1b96eView commit details
Commits on Sep 20, 2023
-
trim quotes on font family name
Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8483b7f - Browse repository at this point
Copy the full SHA 8483b7fView commit details -
making sure the name value differs from fontFamily to validate that t…
…he former is not being used Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e0f88c0 - Browse repository at this point
Copy the full SHA e0f88c0View commit details -
Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 60a5a50 - Browse repository at this point
Copy the full SHA 60a5a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 014b4e3 - Browse repository at this point
Copy the full SHA 014b4e3View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 084e83d - Browse repository at this point
Copy the full SHA 084e83dView commit details -
Because `WP_Font_Face_Resolver` already exists in Core release code, this update cannot be tested in CI without migrating the code into a temporary `_Gutenberg` resolver, which will complicate syncing back to Core. Test will be added to a follow-up PR, to merge once this update is synced to Core. Note that this test does succeed when run locally against WP `trunk` (currently 6.4-alpha).
Configuration menu - View commit details
-
Copy full SHA for 29df9f8 - Browse repository at this point
Copy the full SHA 29df9f8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.