SlotFill: Pass Component instance to unregisterSlot.
#54765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Type] Bug
torounit
changed the title
Component instance to unregisterSlot.SlotFill: Pass Component instance to unregisterSlot.
|
Size Change: -2 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 25, 2023
| @@ -47,7 +47,7 @@ class SlotComponent extends Component { | |||
| const { name, unregisterSlot, registerSlot } = this.props; | |||
|
|
|||
| if ( prevProps.name !== name ) { | |||
| unregisterSlot( prevProps.name ); | |||
| unregisterSlot( prevProps.name, this ); | |||
There was a problem hiding this comment.
Could be a good one to have a unit test for 🤔
There was a problem hiding this comment.
Agreed with @tyxla — let's add a unit test, and then this PR is good to merge!
ciampo
approved these changes
Sep 27, 2023
| @@ -47,7 +47,7 @@ class SlotComponent extends Component { | |||
| const { name, unregisterSlot, registerSlot } = this.props; | |||
|
|
|||
| if ( prevProps.name !== name ) { | |||
| unregisterSlot( prevProps.name ); | |||
| unregisterSlot( prevProps.name, this ); | |||
There was a problem hiding this comment.
Agreed with @tyxla — let's add a unit test, and then this PR is good to merge!
mikachan
pushed a commit
that referenced
this pull request
Jan 3, 2024
mikachan
added a commit
that referenced
this pull request
Jan 3, 2024
mikachan
pushed a commit
that referenced
this pull request
Jan 5, 2024
mikachan
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
part of #51350.
#51350 (comment)
When the slot name is updated, unregisterSlot is executed and the instance is unregistered, but it is not working correctly because the component instance is not passed. Fix this issue.
Why?
bug fix.
How?
add
this.Testing Instructions