Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label enforcer workflow: make accessibility a focus instead of a type #54941

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

priethor
Copy link
Contributor

What?

Removes the limitation of having the Accessibility label along with types of labels like Bug or Enhancement.

At the same time, if this change is approved, a PR will need to have a type-of-task label associated with it. The reasoning behind this is multiple, as not having clear rules for labeling makes it more complicated to contribute and to report and do project management on the project.

Why?

As mentioned by @afercia here.

Regarding the accessibility label, quoting from #54724 (comment)

I think I already pointed out in some other discussion or issue that Accessibility is typically something that spans across different areas of a project. As such, we should be able to add the Accessibility label everywhere. WhethEr it's a Type or other, I don't have strong preferences.

Accessibility in Core Trac used to be a component and was changed to Focus right for that reason. The re=organizazion of the Trac focuses dates early 2014. For more details and the reasoning about Accessibility as focus, see https://make.wordpress.org/core/2014/01/24/trac-focuses/

How?

By removing the label from the list of type labels.

If this PR is approved, I will follow up with renaming the label to remove the [Type] prefix.

@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg GitHub Actions Pull requests that update GitHub Actions code labels Sep 29, 2023
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @priethor!

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this approach.

@priethor priethor merged commit a29512a into trunk Oct 2, 2023
55 checks passed
@priethor priethor deleted the update/treat-a11y-label-as-a-focus-not-type branch October 2, 2023 09:53
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants