Template Parts: Add rename template part command #55339
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +394 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f03551c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8387165600
|
ramonjd
reviewed
Oct 15, 2023
There was a problem hiding this comment.
Smoke tests according to test steps and all is working well for me so far.
The basic knowledge I've amassed from looking at #54271 is that any effort to create smaller, logical components is worth it! Thanks!
Whether or not the template part commands and modals should be managed on their own or alongside patterns
Does the latter mean managed from the patterns package?
Also not sure if I'm comprehending this part of the test steps right:
- Select a non-customized theme provided template part
- Confirm that you do not get the rename template part command
- Customize the template part
- Confirm that you now get the rename command and it works as expected
Should a theme-provided template part have a rename command? In testing it doesn't, but it does allow for clearing customizations, which I'd expect.
Thanks!
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
|
Thanks for the early feedback, testing, and sanity check @ramonjd 🙇
Yeah, at what point should we bring this into the patterns package? Now or only when we're unifying template parts and patterns so the patterns package remains more purely about patterns.
Murky test instructions sorry. The key was to select/click on a template part, taking you to the view page for the template part. On this page, I do get the rename template part command and it does work for step 7. From there, clearing the customizations does mean the template part is back to the original name as the original theme-provided template part is restored. Screen.Recording.2023-10-17.at.5.13.52.pm.mp4So I guess the next question is should I disallow the renaming of template parts even if they have been customized (which creates a copy of the theme-provided part in the corresponding CPT) or allow the renaming of customized template parts from the main Patterns grid view page? What do you think? |
No, it was a complete disregard for the main thrust of this PR (commands) 😄 I can confirm all steps work as expected, thanks for clarifying it.
The ability to customized theme-provided template parts and extend that ability to customizing the title of the post doesn't seem like a great stretch, so yes, in my mind, it's a good feature to have. I'm imagining customizing a template part to such an extent that the default name might not apply anymore. In that case it would serve me, as a site owner and other editors working on the same site, to have a title that reflects the template. In the "Manage all" view, it helps to see that it's a theme-provided template part, even after I've renamed it. I forget things, you see. Going off on a tangent, but perhaps it would also be useful to have the original template title to indicate what sort of template it was before renaming/customization. 
As part of the templates actions drop down or something similar? If the renaming of customized template parts is available via commands I'd think it'd be useful to have it also in the UI for folks who might not be into command-like actions. That's just my 2c! Keen to hear what other folks think. |
aaronrobertshaw
force-pushed
the
try/rename-template-part-command
branch
from
c673833
to
f03551c
Compare
aaronrobertshaw
changed the title
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds a rename template part command.
Note: Whether or not the template part commands and modals should be managed on their own or alongside patterns is still a bit unclear at the moment and likely to change based on feedback.
Refactoring or consolidating the modal components will be looked into via a follow-up.
Why?
This is a step toward parity between the template part and pattern functionality in the site editor. It also lays the ground work for allowing quick duplication of a template part via a duplicate command.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-22.at.5.44.58.PM.mp4
Original incarnation of this pre dataviews for patterns
What?
Adds a rename template part command and simplifies the pattern page's
RenameMenuItemcomponent.Note: Whether or not the template part commands and modals should be managed on their own or alongside patterns is still a bit unclear at the moment and likely to change based on feedback.
Why?
This is a step toward parity between the template part and pattern functionality in the site editor. It also lays the ground work for allowing quick duplication of a template part via a duplicate command.
How?
RenameTemplatePartModalfrom the pattern page'sRenameMenuItemRenameMenuItemto use the new rename modals for patterns and template partsTesting Instructions
Screenshots or screencast
Screen.Recording.2023-10-13.at.6.28.12.pm.mp4