Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked commits for WordPress 6.4 RC2 #55481

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Cherry-picked commits for WordPress 6.4 RC2 #55481

merged 9 commits into from
Oct 23, 2023

Commits on Oct 19, 2023

  1. Focus submenu button when clicked (#55198)

    * Focus element manually when open submenu on click
    
    * Try using `tabindex="-1"`
    
    * Use `tabindex="-1"` also in body when a submenu is opened
    
    * Replace tabindex with event listener
    
    * Explain the tabindex on <li>
    
    * Don't store the element on hover to restore the focus later
    
    * Improve explanations
    
    * Add tests to cover webkit frontend menu interactions
    
    Safari doesn't place focus on a clicked button as expected. These tests verify that when a submenu chevron button is clicked, focus is correctly placed on that button. It also verifies that the click on the body correctly closes any open submenus, which was failing in Safari.
    
    * Focus clicked button on Safari
    
    Combining the tabindex -1 on the parent li and focusing the button on Safari, and also checking that the relatedTarget is null inside the handleMenuFocusout seems to contain the focus within the menu to not fire the handleMenuFocusout as often, and still works to click on the body to close the menu.
    
    * Added the document.addEventListener body click back in
    
    Authored by Luis Herranz <luisherranz@gmail.com>. I'm just re-applying the change.
    
    * Remove tab keypresses from webkit menu interaction tests
    
    Tab keypreses on webkit playwright are really flakey (or it's something in our code that we haven't isolated) so I've split out the webkit tests to test everything I can without using a tab keypress.
    
    * Use body click instead for consistency across environments
    
    ---------
    
    Co-authored-by: Luis Herranz <luisherranz@gmail.com>
    Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com>
    3 people authored and Siobhan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    042dfed View commit details
    Browse the repository at this point in the history
  2. Make layout support compatible with enhanced pagination (#55416)

    * Make layout supports compatible with enhanced pagination
    
    * Use sanitize_title and add `layout` to the class name
    luisherranz authored and Siobhan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    3735244 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f469741 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Make duotone compatible with enhanced pagination (#55415)

    luisherranz authored and Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    687cb22 View commit details
    Browse the repository at this point in the history
  2. Patterns: fix capabilities settings for pattern categories (#55379)

    Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
    2 people authored and Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6f83c92 View commit details
    Browse the repository at this point in the history
  3. Revert "Patterns: fix capabilities settings for pattern categories (#…

    …55379)"
    
    This reverts commit 6f83c92.
    Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a783961 View commit details
    Browse the repository at this point in the history
  4. Image block: wrap images with hrefs in an A tag (#55470)

    * This commit sees what happens when we wrap the image element in an A tag in the editor.
    This is to ensure any inherited styles from the link element, such as border color, apply to the image.
    
    * Removing duplicate <a href /> wrapper
    Adding disabled onClick and aria attribute
    ramonjd authored and Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3ade049 View commit details
    Browse the repository at this point in the history
  5. Image: Improve focus management in lightbox (#55428)

    * Improve focus management
    
    This commit removes the logic to set focus differently
    based on event.pointerType and instead sets focus on the
    dialog itself when the lightbox opens, and on the lightbox
    trigger when the lightbox closes.
    
    * Add delay before focusing when closing lightbox
    
    * Put focus back on close button when opening lightbox
    
    It turns out that placing focus on the modal was causing
    inconsistent behavior in Safari, so I've put the focus back
    on the close button when the lightbox opens, which
    performs predictably.
    
    I've also added a tabindex to the image, which prevents
    the focus ring from erroneously showing when opening the lightbox
    with a mouse in Chrome and Firefox.
    
    * Move focus to the dialog when opening the lightbox.
    
    * Fix SVG markup.
    
    * Consistent indentation with spaces.
    
    * Remove unnecessary tabindex
    
    ---------
    
    Co-authored-by: Andrea Fercia <a.fercia@gmail.com>
    2 people authored and Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    feefbe1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0d36390 View commit details
    Browse the repository at this point in the history