DropdownMenu V2: add support for rendering in legacy popover slot #56342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
ciampo
commented
Nov 20, 2023
There was a problem hiding this comment.
Changes to Storybook will be removed before merging
ciampo
commented
Nov 20, 2023
There was a problem hiding this comment.
Same here, I'll undo these changes before merging
chad1008
approved these changes
Nov 21, 2023
This was referenced Nov 22, 2023
|
I am going to revert this PR according to what discussed in #56482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50459
What?
This PR introduces changes that allow the the new experimental version of
DropdownMenuto render in the same slots as the legacyPopover-based components (including current stableDropdownMenu)Why?
For better backwards compatibility between the new and the legacy version of the component
How?
slotNameprop, or via the popover slot name contextTesting Instructions
DropdownMenucomponent. Open the dropdown menu and make sure that the menu is rendered correctly in the popover slot component (you can do so by inspecting the DOM and comparing it against the default story)DropdownMenucomponent. The two components should behave the same way when picking the solt in which to render their popover.