Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigatorProvider: Exclude size value from contain CSS rule #57498

Merged
merged 2 commits into from
Jan 3, 2024
Merged

NavigatorProvider: Exclude size value from contain CSS rule #57498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a8114d
NavigatorProvider: Exclude size value from contain CSS rule
t-hamano Jan 3, 2024
454f0f3
Update changelog
t-hamano Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- `PaletteEdit`: Don't discard colors with default name and slug ([#54332](https://github.com/WordPress/gutenberg/pull/54332)).
- `RadioControl`: Fully encapsulate styles ([#57347](https://github.com/WordPress/gutenberg/pull/57347)).
- `GradientPicker`: Use slug while iterating over gradient entries to avoid React "duplicated key" warning ([#57361](https://github.com/WordPress/gutenberg/pull/57361)).
- `NavigatorProvider`: Exclude `size` value from `contain` CSS rule ([#57498](https://github.com/WordPress/gutenberg/pull/57498)).

### Enhancements

Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/navigator/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export const navigatorProviderWrapper = css`
/* Prevents horizontal overflow while animating screen transitions */
overflow-x: hidden;
/* Mark this subsection of the DOM as isolated, providing performance benefits
* by limiting calculations of layout, style, paint, size, or any combination
* to a DOM subtree rather than the entire page.
* by limiting calculations of layout, style and paint to a DOM subtree rather
* than the entire page.
*/
contain: strict;
contain: content;
`;

const fadeInFromRight = keyframes( {
Expand Down
Loading