-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual indication of switch to default template in the post editor #57718
Fix visual indication of switch to default template in the post editor #57718
Conversation
Size Change: +1.04 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
This comment was marked as resolved.
This comment was marked as resolved.
6067db6
to
690fc1e
Compare
'postType', | ||
'wp_template', | ||
defaultTemplateId | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So one thing I noticed here is that this function is getting closer to use-init-edited-entity-from-url which is good.
The remaining difference is about the handling of the "posts page" and the "home page", both of these have special handling in the site editor that is not present here. I'm thinking that we might want to check these and unify these as well (probably a separate PR though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that this fixes both issues I was seeing:
- The draft pages not showing the right template in the site editor (theme 2024).
- The right template selected in the sidebar of the post editor when swapping templates.
I'd love if we can test some of these.
There is a test in post editor and a draft page already and I added one more for post editor. |
What?
Fixes: #48577
When using the template switcher in the post editor sidebar to switch from a custom template back to the default one, there is no visual indication that the change was successful. Neither the template name in the sidebar or the layout actually changes.
Why?
As @talldan mentions here, internally we were using
__experimentalGetTemplateForLink
which doesn't take into account unsaved changes(in our case thetemplate
prop) which results in the wrong template resolution. The same problem was encountered in switching templates in site editor and has been resolved with this PR, that introduced thegetDefaultTemplateId
selector I'm using here.Testing Instructions
Screenshots or screencast
Screen.Recording.2024-01-10.at.2.25.00.PM.mov