Update the cherry pick script to work with the new version of gh #57917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
commented
Jan 17, 2024
| title, | ||
| pull_request, | ||
| } ) ) | ||
| const PRs = items |
There was a problem hiding this comment.
These are all just linting changes.
scruffian
added
Backport to Gutenberg RC
mikachan
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The latest version of
ghoutputs this forauth status:Logged in to github.com account....instead ofLogged in to github.com as.This changes the condition under which we check that someone is logged in to work with both versions.
Testing Instructions
Update to the latest version of
ghTry running the script
npm run other:cherry-pick "Backport to Gutenberg RC"but then cancel it before it runs.On trunk you'll see an error that gh isn't installed. On this branch you should see a message telling you what will change.