Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing PHP errors trigger by navigation link block #58069

Closed
wants to merge 2 commits into from

Conversation

Mamaduka
Copy link
Member

What?

Just testing a theory. I can't reproduce issue on my local set up.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Jan 22, 2024
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/blocks/block-navigation-link-variations-test.php

Copy link

Flaky tests detected in 149a9b0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7610165222
📝 Reported issues:

@Mamaduka
Copy link
Member Author

I thought I could resolve the problem by reverting changes from #56100. The hook registration order is not important now that variations are lazily evaluated.

But other test cases are still failing, so we need a more general solution. Ticket: https://core.trac.wordpress.org/ticket/60309.

@Mamaduka Mamaduka closed this Jan 22, 2024
@Mamaduka Mamaduka deleted the try/fix-nav-link-block-php-errors branch January 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant