DataViews: Fix some small issues with featured image #58371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal and
jameskoster
ntsekouras
commented
Jan 29, 2024
| position: relative; | ||
| background-color: $gray-100; | ||
| overflow: hidden; | ||
| flex-grow: 0 !important; |
There was a problem hiding this comment.
These styles were just moved, except for this added line. In general I'm not very fond of the styles we're adding because of the need to have a wrapper(dataviews-view-table__cell-content-wrapper) with display:flex, in table view.
ntsekouras
commented
Jan 29, 2024
| <span | ||
| className={ { | ||
| <button | ||
| className={ classNames( 'page-pages-preview-field__button', { |
There was a problem hiding this comment.
This was just a bug, that we weren't calling classNames.
ntsekouras
commented
Jan 29, 2024
| @@ -162,31 +170,27 @@ function FeaturedImage( { item, viewType } ) { | |||
| } ); | |||
| const hasMedia = !! item.featured_media; | |||
| return ( | |||
| <span | |||
| className={ { | |||
| <button | |||
There was a problem hiding this comment.
The changes here are just the removal of the span wrapper.
|
Size Change: +31 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8ec4e1f005b1d952f7e3f80f7722d66bae4a57af. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7694815630
|
This was referenced Jan 29, 2024
|
Thanks Nik
If we apply Width 1%
Current
For List layout I think I'd expect featured image to be an optional field. We need to decide in Grid layout whether the media element should be optional or not. I lean towards yes, but this leads to another question; should field visibility always be synced across layouts? Probably one to follow up on. What do you think? 
The vertical alignment here looks a little clunky. We should probably use 32x32 thumbnails in Table layout to fix the that: 
|
ntsekouras
force-pushed
the
fix/dataviews-pages-view-layout-config
branch
from
8ec4e1f
to
0040299
Compare
I think so too. I believe we shouldn't have a required
Besides the featured image(which is something to discuss for the above point), they should and they do in templates lists and patterns. There seems to be an issue for pages list, that I'll investigate. Both issues though should be follow ups. |
ntsekouras
commented
Jan 29, 2024
| @@ -42,4 +15,32 @@ | |||
| // Windows High Contrast mode will show this outline, but not the box-shadow. | |||
| outline: 2px solid transparent; | |||
| } | |||
|
|
|||
| &.edit-site-page-pages__media-wrapper { | |||
| width: $grid-unit-40; | |||
There was a problem hiding this comment.
width and height were also updated to use $grid-unit-40 instead of $grid-unit-50.
jameskoster
approved these changes
Jan 29, 2024
mcsf
approved these changes
Jan 29, 2024
It seems we intend to stick to having it hidden and I think there are suggestions to remove it completely, or at least use it as part of a 'summary' field alongside with title, etc.. |
|
@ntsekouras I'm seeing some peculiar behavior with the preview field on the templates page in list layout. Could it be related to this PR? 🤔 
|
Yes and no :). My PR exposed an existing bug. Thanks for catching it! I opened a follow up here: #58400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently if we are in the
Manage all pagespage and intableview, we cannot select thefeatured imagefield to be shown.Additionally I'm removing an extra wrapper we had for the featured image and fixed a bug, where we weren't adding a css class conditionally.
Testing Instructions
Manage all pagespagefeatured imagefield through the options when intableview. Verify that is displayed as should. Noting that the column cannot be smaller due to the field'sheader.featured imagefield is displayed as expect in the other views(list and grid).