Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docblock for render_block_core_pattern #58382

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Jan 29, 2024

What?

Updates the docblock for render_block_core_pattern to mention the $wp_embed global is used.

Why?

To comply with coding standards. See WordPress/wordpress-develop#5922 (comment) where it was found during the package updates for WP6.5

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@dsas dsas requested a review from ajitbohra as a code owner January 29, 2024 13:23
@dsas dsas added [Block] Pattern Affects the Patterns Block [Type] Code Quality Issues or PRs that relate to code quality labels Jan 29, 2024
@youknowriad youknowriad added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 29, 2024
@youknowriad youknowriad merged commit 8585de2 into WordPress:trunk Jan 29, 2024
57 of 59 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 29, 2024
@cbravobernal
Copy link
Contributor

I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 484d2f1

@cbravobernal cbravobernal removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pattern Affects the Patterns Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants