Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Update the Snackbar warning message #58591

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 2, 2024

What?

PR updates the Snackbar warning message copy to fix minor grammar issues.

Testing Instructions

  1. Open a post or page.
  2. Run snippet via DevTools console.
  3. Confirm that the updated message is displayed.
// more then 1 action
wp.data.dispatch('core/notices').createNotice(
		'info',
		'Post published.', // Text string to display.
		{
			isDismissible: true, // Whether the user can dismiss the notice.
			// Any actions the user can perform.
			type: 'snackbar',
            actions: [
				{
					onClick: () => console.log( 'test' ),
					label: 'View post'
				},
				{
					onClick: () => console.log( 'test' ),
					label: 'View post'
				}
			]
		}
	);

@Mamaduka Mamaduka added [Type] Copy Issues or PRs that need copy editing assistance [Package] Components /packages/components labels Feb 2, 2024
@Mamaduka Mamaduka self-assigned this Feb 2, 2024
@Mamaduka Mamaduka requested review from t-hamano and removed request for ajitbohra February 2, 2024 05:08
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍What do you think about adding this change to the CHANGELOG as an enhancement?

Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: mamaduka, wildworks.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

Mamaduka commented Feb 2, 2024

@t-hamano
Copy link
Contributor

t-hamano commented Feb 2, 2024

you might want to add WP.org email to your GH account

I had already added the email address to my GitHub account, but since I recently changed the password on my GitHub account, it appears that the connection with WP.org had been broken.

After re-linking and re-running the Props bot, it appears that the comment was updated correctly👍

@Mamaduka Mamaduka merged commit ef346a6 into trunk Feb 2, 2024
57 checks passed
@Mamaduka Mamaduka deleted the update/snackbar-warning branch February 2, 2024 07:52
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants