Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnglePickerControl: Hard deprecate bottom margin #58700

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 5, 2024

Part of #39358

What?

Promotes __nextHasNoMarginBottom on AnglePickerControl to the default behavior.

Why?

The deprecation grace period has elapsed.

Testing Instructions

In the Storybook for AnglePickerControl, turn on the margin checker tool in the toolbar. The margin-free styles should now be the default, and the __nextHasNoMarginBottom prop should not be listed in the props table.

✅ AnglePickerControl is not directly used in the Gutenberg app.
✅ All internal components that use AnglePickerControl under the hood are already using it in margin-free mode.

✍️ Dev Note

See Dev Note for #58699.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Needs Dev Note Requires a developer note for a major WordPress release cycle labels Feb 5, 2024
@mirka mirka self-assigned this Feb 5, 2024
@mirka mirka requested a review from ajitbohra as a code owner February 5, 2024 23:33
Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: 0mirka00, mciampini.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team February 5, 2024 23:35
@mirka mirka mentioned this pull request Feb 5, 2024
20 tasks
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mirka mirka merged commit 6d97038 into trunk Feb 6, 2024
59 checks passed
@mirka mirka deleted the angle-picker-control-margin branch February 6, 2024 13:19
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 6, 2024
@mirka mirka added has dev note when dev note is done (for upcoming WordPress release) and removed Needs Dev Note Requires a developer note for a major WordPress release cycle labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dev note when dev note is done (for upcoming WordPress release) [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants