Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use disabled attribute to disable block mover buttons #588

Merged
merged 2 commits into from
May 1, 2017
Merged

Use disabled attribute to disable block mover buttons #588

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
621f542
Use `disabled` attribute to disable block mover buttons
nylen May 1, 2017
0b5ec63
Incoming isFirst / isLast props are already booleans
nylen May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions editor/components/block-mover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* External dependencies
*/
import { connect } from 'react-redux';
import classnames from 'classnames';
import { first, last } from 'lodash';

/**
Expand All @@ -15,14 +14,16 @@ function BlockMover( { onMoveUp, onMoveDown, isFirst, isLast } ) {
return (
<div className="editor-block-mover">
<IconButton
className={ classnames( 'editor-block-mover__control', { 'is-disabled': isFirst } ) }
className="editor-block-mover__control"
onClick={ onMoveUp }
icon="arrow-up-alt2"
disabled={ !! isFirst }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of types make it not so obvious, but we should (and currently can) assume the incoming value is already a boolean.

/>
<IconButton
className={ classnames( 'editor-block-mover__control', { 'is-disabled': isLast } ) }
className="editor-block-mover__control"
onClick={ onMoveDown }
icon="arrow-down-alt2"
disabled={ !! isLast }
/>
</div>
);
Expand Down
5 changes: 3 additions & 2 deletions editor/components/block-mover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
color: $dark-gray-900;
}

&.is-disabled {
color: $light-gray-100;
&[disabled] {
cursor: default;
color: $light-gray-300;
}

.dashicon {
Expand Down