Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Increase footnotes meta priority and separate footnotes meta registration. #58882

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Update: Increase footnotes meta priority and separate footnotes meta registration. #58882

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b017fc
Update: Increate footnotes meta priority and separate footnotes meta …
jorgefilipecosta Feb 9, 2024
6b0efec
Include footnotes on non public cpts
jorgefilipecosta Feb 12, 2024
11f145a
Update packages/block-library/src/footnotes/index.php
jorgefilipecosta Feb 16, 2024
a197383
Update to use WordPress multiline comments.
jorgefilipecosta Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/block-library/src/footnotes/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ function register_block_core_footnotes_post_meta() {
}
}
}
// Most post types are registered at priority 10, so use priority 20 here in
// order to catch them.
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgefilipecosta Sorry, I missed this at the time -- comments should start with /* (a single asterisk) rather than a double asterisk). The latter is used for docblocks only to allow them to be picked up by parser for developer.wordpress.org

Are you able to do a follow up commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure doing a follow up fix, thank you for catching this 👍

* Most post types are registered at priority 10, so use priority 20 here in
* order to catch them.
*/
add_action( 'init', 'register_block_core_footnotes_post_meta', 20 );

/**
Expand Down
Loading