Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: background UI controls #59454

Merged
merged 14 commits into from
Mar 27, 2024
Merged

Commits on Mar 26, 2024

  1. Initial commit - not finished.

    Starting to set up global styles and refactor existing background components
    
    Porting over existing hook code to shared, global styles component.
    Next step is to gut the existing hook and set up props using setAttribute etc
    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    37885fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16fdfab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    149f24b View commit details
    Browse the repository at this point in the history
  4. We don't need useSettingsForBlockElement() yet because we're not deal…

    …ing with blocks. I think that's the way it works.
    
    We don't need useSettingsForBlockElement() yet because we're not dealing with blocks. I think that's the way it works.
    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    935cab1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ae62a65 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c15eeeb View commit details
    Browse the repository at this point in the history
  7. Add default control values for block supports. The default background…

    …Size value for block backgrounds is 'cover'
    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    57dd8a9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e29f5be View commit details
    Browse the repository at this point in the history
  9. Resetting position if it's center and size is not contain.

    We don't use named values yet, only percentages, so it should be safe
    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    26256e2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    653d32a View commit details
    Browse the repository at this point in the history
  11. Add background-image to INDIRECT_PROPERTIES_METADATA because the valu…

    …e is "indirectly" stored in an array, at least determined by multiple values in an array.
    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    85045e4 View commit details
    Browse the repository at this point in the history
  12. Turning on by default.

    ramonjd committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2d338de View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. revert theme.json changes

    ramonjd committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d905887 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
    ramonjd and andrewserong committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fc98542 View commit details
    Browse the repository at this point in the history