Update: Move post actions to the editor package. #60092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.13 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/move-post-actions-to-the-editor-package
branch
2 times, most recently
from
468e435
to
4d77010
Compare
mcsf
reviewed
Mar 29, 2024
Comment on lines
42
to
43
| const { postManagementActions } = unlock( editorPrivateApis ); | ||
| const { usePostActions } = postManagementActions; |
There was a problem hiding this comment.
Do we expect future changes where consumers directly import the actions from postManagementActions? In this branch we only ever import usePostActions, so unless there are specific plans we could just export less:
lock( privateApis, {
// ...
usePostActions
} );| const actions = useMemo( | ||
| () => [ | ||
| editTemplateAction, | ||
| postActions.find( ( action ) => action.id === 'edit-post' ), |
There was a problem hiding this comment.
Should usePostActions accept an array of action IDs, so that we don't have to do this?
const [ editAction, viewRevisionsAction ] = usePostActions(
{ onActionPerformed },
[ 'edit-post', 'view-post-revisions' ]
);
const actions = useMemo(
() => [ editAction, resetTemplateAction, /* ... */ ],
[ editAction, viewRevisionsAction ]
);| }, | ||
| }; | ||
|
|
||
| export function usePostActions( { onActionPerformed } ) { |
There was a problem hiding this comment.
What was the reasoning behind passing the sole argument in an object? Since we're dealing with a new and private API, I'd be more confident and just have:
function usePostActions( onActionPerformed ) {
|
I pushed three commits implementing my review suggestions. Let me know what you think, @jorgefilipecosta. |
mcsf
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Approved as far as I'm concerned. @jorgefilipecosta, I'll leave it up to you to merge if you agree with my changes, otherwise let me know. :)
jorgefilipecosta
force-pushed
the
update/move-post-actions-to-the-editor-package
branch
from
cc4a802
to
5f4c899
Compare
jorgefilipecosta
deleted the
update/move-post-actions-to-the-editor-package
branch
|
Thank you a lot for all the suggestions and for adding commits. All the suggestions made sense 👍 |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59849.
This PR moves the post actions to the editor package. And introduces a new usePostActions with a global onActionPerformed function as discussed #59849 (review).
For now, the actions are not used in new places we just use them on data views as before.
After this PR and #59870 are merged we are going to unify post actions across dataviews, post details panel, and post inspector panel.
Testing