Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Autocomplete popover #60131

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Polish Autocomplete popover #60131

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31fbbc3
Try accent background
richtabor Mar 22, 2024
6dd6122
Improve focus/active
richtabor Mar 22, 2024
599016b
update changelog
draganescu Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/components/src/autocomplete/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.components-autocomplete__popover .components-popover__content {
padding: $grid-unit-20;
min-width: 220px;
padding: $grid-unit-10;
min-width: 200px;
}

.components-autocomplete__result.components-button {
Expand All @@ -10,7 +10,13 @@
text-align: left;
width: 100%;

&.is-selected {
box-shadow: 0 0 0 var(--wp-admin-border-width-focus) $components-color-accent;
&:focus:not(:disabled) {
@include block-toolbar-button-style__focus();
}

&.is-selected,
&:not(:disabled,[aria-disabled="true"]):active {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary to include [aria-disabled="true"] in this selector. Because the Button component inside the Autocompleter never has this attribute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sometimes it could have it?

background: $components-color-accent;
color: $white;
}
}
Loading