AlignmentMatrixControl: Promote to stable #60913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
added
[Package] Components
fullofcaffeine
force-pushed
the
remove/wp-components-experimental-designation-for-alignmentmatrixcontrol
branch
2 times, most recently
from
e5caade
to
ac94762
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
13 tasks
fullofcaffeine
changed the title
AlignmentMatrixControlAlignmentMatrixControl
mirka
force-pushed
the
remove/wp-components-experimental-designation-for-alignmentmatrixcontrol
branch
from
ac94762
to
567b352
Compare
mirka
changed the title
AlignmentMatrixControl
mirka
reviewed
Aug 30, 2024
Comment on lines
+4
to
+8
| 'alignmentmatrixcontrol', | ||
| 'customselectcontrol-v2', | ||
| 'theme', | ||
| 'navigation', | ||
| 'progressbar', | ||
| 'theme', |
|
Size Change: +26 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM 👍
Thanks, @fullofcaffeine, for the initial work and for getting it to the finish line @mirka! 🚀
packages/components/CHANGELOG.md
Outdated
| @@ -357,6 +358,7 @@ | |||
| ### Deprecations | |||
|
|
|||
| - `Navigation`: Soft deprecate component ([#59182](https://github.com/WordPress/gutenberg/pull/59182)). | |||
| - `AlignmentMatrixControl`: Remove "experimental" designation ([#60913](https://github.com/WordPress/gutenberg/pull/60913)). | |||
There was a problem hiding this comment.
Seems like we're adding this to the wrong release. Should this go up in its own new Deprecations section?
Comment on lines
+114
to
+116
| Icon: Object.assign( AlignmentMatrixControlIcon, { | ||
| displayName: 'AlignmentMatrixControl.Icon', | ||
| } ), |
ciampo
reviewed
Aug 30, 2024
| @@ -12,7 +12,11 @@ export { | |||
| } from '@wordpress/primitives'; | |||
|
|
|||
| // Components. | |||
| export { default as __experimentalAlignmentMatrixControl } from './alignment-matrix-control'; | |||
| export { | |||
| /** @deprecated Import `AlignmentMatrixControl` instead. */ | |||
There was a problem hiding this comment.
Do we plan on adding a deprecation warning in a follow-up once all instances are migrated, or are we keeping it "soft deprecated" for now?
There was a problem hiding this comment.
I'm thinking we can decide on a per-component basis, using reasoning from #61099. Maybe we'll want to do a more aggressive cleanup in the future, but I don't think it's a pressing need for the moment. I'm anticipating most of these to be passive deprecations.
|
Flaky tests detected in 6c062f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10638099802
|
|
Seems like this got conflicted and will need a rebase. |
…on-for-alignmentmatrixcontrol
mirka
deleted the
remove/wp-components-experimental-designation-for-alignmentmatrixcontrol
branch
fabiankaegy
added
the
Needs Dev Note
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Remove "experimental" designation for `AlignmentMatrixControl` * Add CHANGELOG entry * Tweak exports * Replace in app * Add changelog * Fix changelog --------- Co-authored-by: fullofcaffeine <fullofcaffeine@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59418
What?
Promote
AlignmentMatrixControlto a non-experimental component.Why?
The strategy of prefixing exports with
__experimentalhas become deprecated after the introduction of private APIs.Checklist
__experimentalprefix.__experimentalexport for backwards compatibility.__experimentalin GB and components to the one without the prefix (including in Storybook stories).id(get it from the storybook URL) to thePREVIOUSLY_EXPERIMENTAL_COMPONENTSconst array inmanager-head.htmlso that old experimental story paths are redirected to the new one.