Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Assess stabilization of View #61074

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

fullofcaffeine
Copy link
Member

Issue: #59418.

What?

This is part of a larger effort to remove __experimental prefix from all "experimental" components, effectively promoting them to regular stable components. See the related issue for more context.

Why?

The strategy of prefixing exports with __experimental has become deprecated after the introduction of private APIs.

How?

  1. Export it from components without the __experimental prefix;
  2. Keep the old __experimental export for backwards compatibility;
  3. Change all imports of the old __experimental in GB and components to the one without the prefix (including in storybook stories). Also, update the docs to refer to the new unprefixed component;
  4. Add the component storybook id (get it from the storybook URL) to the PREVIOUSLY_EXPERIMENTAL_COMPONENTS const array in manager-head.html so that old experimental story paths are redirected to the new one;
  5. Add a changelog for the change.

@fullofcaffeine fullofcaffeine added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Apr 25, 2024
@fullofcaffeine fullofcaffeine self-assigned this Apr 25, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with a passive deprecation on this one, since this is mostly used for the Emotion as prop, and we're moving away from both Emotion and as patterns. I don't think this ever has to be used anywhere.

We may have to eventually move to a stronger deprecation, depending on what we decide to do about Emotion/as.

cc @DaniGuardiola

@fullofcaffeine
Copy link
Member Author

fullofcaffeine commented Apr 30, 2024

@lena Thanks! What should we document in the deprecation comment as the alternative for this component?

@fullofcaffeine fullofcaffeine changed the title Components: Remove "experimental" designation for View Components: Assess stabilization of View Apr 30, 2024
@fullofcaffeine
Copy link
Member Author

I think we should go with a passive deprecation on this one, since this is mostly used for the Emotion as prop, and we're moving away from both Emotion and as patterns. I don't think this ever has to be used anywhere.

AFAIU, this is already being passively deprecated as per #61099, no? Do you mean that we shouldn't re-report the unprefixed View? Also, what should we put in the deprecation message in that case?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants