Verse block: add background image and minimum height support #62498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… display varying image heights, also opt in to minimum height, but not as default controls
ramonjd
added
[Type] Enhancement
ramonjd
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
69 tasks
ramonjd
commented
Jun 12, 2024
| "backgroundImage": true, | ||
| "backgroundSize": true, | ||
| "__experimentalDefaultControls": { | ||
| "backgroundImage": true |
There was a problem hiding this comment.
Should we collapse the background image tools panel by default?
I'm tending towards "yes" to avoid clutter.
There was a problem hiding this comment.
Ignore this. It's pretty compact
tellthemachines
approved these changes
Jun 12, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ss#62498) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for background images for the Verse block.
For flexibility to display varying image heights, it also opts in to minimum height, but not as a default control.
Why?
The Verse block contains a pre element that formats text as it would be presented in the browser. Top notch for poetry!
The ability to add background images extends visual differentiation, and allows users to set unique design patterns.
Example:
As for adding minimum height support, it ensures that users can adequately space Verse blocks to accommodate taller images.
How?
Turning on the block supports in block.json
Testing Instructions
Add a Verse block to a post.
Select a background image, and play around with minimum height and other styles according to your fancy.
Here's some HTML to get you started: