Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectControl: Fix disabled styles #63266

Merged
merged 4 commits into from
Jul 9, 2024
Merged

SelectControl: Fix disabled styles #63266

merged 4 commits into from
Jul 9, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Jul 8, 2024

What?

Fixes disabled styles for SelectControl (caret color and cursor style).

Testing Instructions

See the Storybook for SelectControl.

Screenshots or screencast

Before After
Wrong disabled styles Correct disabled styles

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 8, 2024
@mirka mirka self-assigned this Jul 8, 2024
@mirka mirka requested a review from ajitbohra as a code owner July 8, 2024 18:39
Copy link

github-actions bot commented Jul 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team July 8, 2024 18:39
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Looks like some snapshots need to be updated, but everything else LGTM

@mirka mirka enabled auto-merge (squash) July 9, 2024 12:57
@mirka mirka merged commit ae20515 into trunk Jul 9, 2024
61 checks passed
@mirka mirka deleted the fix/select-control-disabled branch July 9, 2024 13:31
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 9, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jul 10, 2024
* SelectControl: Fix disabled styles

* Add changelog

* Update snapshots

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
* SelectControl: Fix disabled styles

* Add changelog

* Update snapshots

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants