Patterns inserter tabs: temporary disable animated indicator #63352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Bug
|
Size Change: +41 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 10, 2024
tyxla
approved these changes
Jul 10, 2024
ciampo
force-pushed
the
fix/patterns-inserter-remove-tabs-animation
branch
from
bb788f2
to
d54612b
Compare
|
Thanks for this! |
|
@DaniGuardiola now that the release is up there, it may be a good idea to follow up on this one, following the rough plan @ciampo suggested in the PR description above. |
|
@tyxla yes, we already have 2 people in the design group who have manifested support for a certain option, so I think I'm gonna try it out and get design approval as a first step. In parallel, I'll investigate the jankyness. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ss#63352) * Patterns inserter tabs: temporary disable animated indicator * Apply feedback --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As discussed in #62879 (comment), this PR disables the animated indicator from the
Tabscomponent in the patterns inserter.Why?
The new animation conflicts with the current custom indicator styles. This PR aims at putting a temporary stopgap until we come up with a better solution.
How?
By adding a CSS override hiding the animated indicator.
Next steps
To be carried out in separate PRs, cc @DaniGuardiola:
Tabscomponent, both in horizontal and vertical orientations, that can be used across the whole editorTesting Instructions
Screenshots or screencast
tabs-patterns-inserter-before.mp4
tabs-patterns-inserter-after.mp4