List View: remove the sticky position icon tooltip #63850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ciampo
added
[Package] Block editor
ciampo
force-pushed
the
fix/list-view-remove-sticky-position
branch
from
10d9b71
to
29bee42
Compare
|
Flaky tests detected in 29bee42. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10058625677
|
t-hamano
approved these changes
Jul 23, 2024
ciampo
force-pushed
the
fix/list-view-remove-sticky-position
branch
from
29bee42
to
6586f66
Compare
|
Nice, thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #59409
Removes the tooltip surrounding the sticky position icon in the list view.
Why?
Tooltipnot to work as expected (it currently doesn't render ontrunk)How?
Tooltipand replaced it with aspan, like it's currently done with other icons in the list viewNote
Adding the "position" text to the list item's description text is optional and can be removed if we don't think it represents an improvement (see related comment).
Testing Instructions
trunk)Screenshots or screencast