Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky DataViews list layout e2e tests #64244

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix flaky DataViews list layout e2e tests #64244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,15 @@ test.describe( 'Dataviews List Layout', () => {
await page.keyboard.press( 'Tab' );
await page.keyboard.press( 'Tab' );

const firstItem = page
.getByRole( 'grid' )
.getByRole( 'button' )
.first();

// Make sure the items have loaded before reaching for the 1st item in the list.
await expect( page.getByRole( 'grid' ) ).toBeVisible();
await page.keyboard.press( 'Tab' );
await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused();
await expect( firstItem ).toBeFocused();

// Go to the preview.
await page.keyboard.press( 'Tab' );
Expand All @@ -91,7 +96,7 @@ test.describe( 'Dataviews List Layout', () => {

// Go back to the items list using SHIFT+TAB.
await page.keyboard.press( 'Shift+Tab' );
await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused();
await expect( firstItem ).toBeFocused();
} );

test( 'Navigates the items list via UP/DOWN arrow keys', async ( {
Expand Down
Loading