Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image: ensure consistency with defaults and fix reset/remove functionality #64328

Merged
merged 10 commits into from
Aug 9, 2024

Commits on Aug 7, 2024

  1. Fixes miscellaneous bugs in the background image default values and c…

    …ontrols.
    
    - checks global styles for uploaded images and applies defaults
    - changes the default position from "center" to "50% 50%" so it displays in the controls
    - ensures that reset/remove functionality closes the panel and removes image
    - do not save already-inherited styles to the block, and don't apply defaults where an inherited style already exists.
    ramonjd committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    77476fc View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    ed33338 View commit details
    Browse the repository at this point in the history
  2. Ensure defaults are accurately displayed in the background control pa…

    …nel.
    
    Add defaults for position '50% 50%' for blocks so it can be displayed in the background panel controls
    Pass inherited values to setBackgroundStyleDefaults so as not apply/overwrite inherited styles.
    Tighten up logic in setBackgroundStyleDefaults so that background position isn't set when an inherited value is contain and the block style is something else.
    ramonjd committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c882568 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e447e73 View commit details
    Browse the repository at this point in the history
  4. Update tests.

    ramonjd committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b7f46ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    42b4c3a View commit details
    Browse the repository at this point in the history
  6. Simplify the inheritence checks. For uploaded images in global styles…

    … and block supports, always apply the defaults.
    ramonjd committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    af1be8c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b72c288 View commit details
    Browse the repository at this point in the history
  8. Changelog

    ramonjd committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7a6e45d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    321ce91 View commit details
    Browse the repository at this point in the history