-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background image: ensure consistency with defaults and fix reset/remove functionality #64328
Merged
Commits on Aug 7, 2024
-
Fixes miscellaneous bugs in the background image default values and c…
…ontrols. - checks global styles for uploaded images and applies defaults - changes the default position from "center" to "50% 50%" so it displays in the controls - ensures that reset/remove functionality closes the panel and removes image - do not save already-inherited styles to the block, and don't apply defaults where an inherited style already exists.
Configuration menu - View commit details
-
Copy full SHA for 77476fc - Browse repository at this point
Copy the full SHA 77476fcView commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed33338 - Browse repository at this point
Copy the full SHA ed33338View commit details -
Ensure defaults are accurately displayed in the background control pa…
…nel. Add defaults for position '50% 50%' for blocks so it can be displayed in the background panel controls Pass inherited values to setBackgroundStyleDefaults so as not apply/overwrite inherited styles. Tighten up logic in setBackgroundStyleDefaults so that background position isn't set when an inherited value is contain and the block style is something else.
Configuration menu - View commit details
-
Copy full SHA for c882568 - Browse repository at this point
Copy the full SHA c882568View commit details -
Configuration menu - View commit details
-
Copy full SHA for e447e73 - Browse repository at this point
Copy the full SHA e447e73View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7f46ee - Browse repository at this point
Copy the full SHA b7f46eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42b4c3a - Browse repository at this point
Copy the full SHA 42b4c3aView commit details -
Simplify the inheritence checks. For uploaded images in global styles…
… and block supports, always apply the defaults.
Configuration menu - View commit details
-
Copy full SHA for af1be8c - Browse repository at this point
Copy the full SHA af1be8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b72c288 - Browse repository at this point
Copy the full SHA b72c288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a6e45d - Browse repository at this point
Copy the full SHA 7a6e45dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 321ce91 - Browse repository at this point
Copy the full SHA 321ce91View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.