Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add 40px size prop to readmes #64592

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Components: Add 40px size prop to readmes #64592

merged 2 commits into from
Aug 18, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 16, 2024

Part of #46741

What?

Document the __next40pxDefaultProp in all applicable component READMEs.

Why?

These were documented in Storybook but not in any of the READMEs.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Aug 16, 2024
@mirka mirka self-assigned this Aug 16, 2024
@mirka mirka requested a review from ajitbohra as a code owner August 16, 2024 22:52
Copy link

github-actions bot commented Aug 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team August 16, 2024 22:56
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mirka mirka merged commit 6992883 into trunk Aug 18, 2024
62 of 63 checks passed
@mirka mirka deleted the components-40px-readme branch August 18, 2024 20:25
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 18, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
* Components: Add 40px size prop to readmes

* Fixup

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants