Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try/refactor insertion #65282

Draft
wants to merge 29 commits into
base: trunk
Choose a base branch
from
Draft

Try/refactor insertion #65282

wants to merge 29 commits into from

Commits on Sep 10, 2024

  1. Use index instead of insertionIndex

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    322a89a View commit details
    Browse the repository at this point in the history

  2. Revert "Use index instead of insertionIndex" 

    This reverts commit df849a9.
    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d068679 View commit details
    Browse the repository at this point in the history

  3. Move/Add inserterInsertionPoint to block editor

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0b3a2b5 View commit details
    Browse the repository at this point in the history

  4. Update the docs of setIsInserterOpened

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e0e0d93 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary props since they won't be set

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c0beea3 View commit details
    Browse the repository at this point in the history

  6. Discourage use of rootIndex and insertionIndex on setIsInserterOpened

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3271edc View commit details
    Browse the repository at this point in the history

  7. Remove note

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9c4e549 View commit details
    Browse the repository at this point in the history

  8. Use setInserterInsertionPoint in quick inserter

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    efa5ffe View commit details
    Browse the repository at this point in the history

  9. Insert in correct location for root insertions

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a90bb7f View commit details
    Browse the repository at this point in the history

  10. Add store tests and improve docs and default state

    @jeryj
    jeryj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c3f9b88 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Use inserterInsertionPoint for zoom out inserters and zoom out separator

    @jeryj
    jeryj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    960154f View commit details
    Browse the repository at this point in the history

  2. Remove blockInsertionPointVisible from zoom out mode inserters

    @jeryj
    jeryj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f81419b View commit details
    Browse the repository at this point in the history

  3. Fix dragging vertical displacement on insertion points

    @jeryj
    jeryj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    62e12a1 View commit details
    Browse the repository at this point in the history

  4. Fix inserting at 0 index on zoom out mode

    @jeryj
    jeryj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0547cdb View commit details
    Browse the repository at this point in the history

  5. Fix insertion point at root level

    @jeryj
    jeryj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6e858a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Rename show/hideInsertionPoint to show/hideInsertionCue and deprecate… 

    … related actions and selectors
    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7a1e21e View commit details
    Browse the repository at this point in the history

  2. Rename store(editor).getInsertionPoint to store(editor).getInserterPanel

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3333ccb View commit details
    Browse the repository at this point in the history

  3. Update block editor store actions tests

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9a45ac0 View commit details
    Browse the repository at this point in the history

  4. Update remaining inserterInsertionPoint to insertionPoint

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d364c5d View commit details
    Browse the repository at this point in the history

  5. Rename show/hideInsertionPoint to show/hideInsertionCue

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e31ff85 View commit details
    Browse the repository at this point in the history

  6. getInsertionPoint powers useInsertionPoint

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    94c2c58 View commit details
    Browse the repository at this point in the history

  7. Rename isBlockInsertionPointVisible to isInsertionCueVisible

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c3eb08e View commit details
    Browse the repository at this point in the history

  8. Fix bugs around getInsertionPoint fallbacks

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2c6d913 View commit details
    Browse the repository at this point in the history

  9. Fix drag on insertion points. Change getInsertionPoint to raw state a… 

    …nd add getNextInsertionPoint
    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8b86e6e View commit details
    Browse the repository at this point in the history

  10. Add clientId back in to useInsertionPoint

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    859e021 View commit details
    Browse the repository at this point in the history

  11. Refactor out getBlockInsertionPoint

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2ce5db0 View commit details
    Browse the repository at this point in the history

  12. Fix unit tests

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a259e80 View commit details
    Browse the repository at this point in the history

  13. Fix zoom out inserter showing with vertical displacement

    @jeryj
    jeryj committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4406ba1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Will revert: Test for block editor insertion performance 

    There's a lot happening within the inserter select well before we seemingly need any of it. How much of this do we need to constantly fire? Can't we delay checking it until we've clicked the toggle?
    @jeryj
    jeryj committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    67ca4c6 View commit details
    Browse the repository at this point in the history