Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useEvent from components package #65388

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove useEvent from components package #65388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247fe56
Replace imports of `useEvent` with `@wordpress/compose`
DaniGuardiola Sep 17, 2024
23ddcd1
Remove `useEvent` from components package
DaniGuardiola Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/components/src/utils/element-rect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
* WordPress dependencies
*/
import { useLayoutEffect, useRef, useState } from '@wordpress/element';
import { useResizeObserver } from '@wordpress/compose';
/**
* Internal dependencies
*/
import { useEvent } from './hooks/use-event';
import { useEvent, useResizeObserver } from '@wordpress/compose';

/**
* The position and dimensions of an element, relative to its offset parent.
Expand Down
38 changes: 0 additions & 38 deletions packages/components/src/utils/hooks/use-event.ts
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions packages/components/src/utils/hooks/use-on-value-update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@
/**
* WordPress dependencies
*/
import { useEvent } from '@wordpress/compose';
import { useRef, useEffect } from '@wordpress/element';
/**
* Internal dependencies
*/
import { useEvent } from './use-event';

/**
* Context object for the `onUpdate` callback of `useOnValueUpdate`.
Expand Down
Loading