Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query No Results: Add block example #65555

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

aaronrobertshaw
Copy link
Contributor

Part of: #64707
Related: #65430

What?

Adds a block example definition for the Query No Results block.

Why?

The Style Book is being iterated on and part of that effort is to ensure the desired blocks are shown there. Currently, this is dependent on blocks having an example defined.

How?

Adds an example to the Query No Results block.

Testing Instructions

As the No Results block is only available via the quick inserter when a Query block is selected there's no inserter preview.

  1. Navigate to the Style Book, (Appearance > Editor > Styles > Style Book icon) and switch to the "Theme" tab.
  2. Confirm the Query No Results block is displayed here

Screenshots or screencast

Screenshot 2024-09-23 at 3 02 18 pm

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] No Results Affects the No Results Block - used when a Query Loop returns no results labels Sep 23, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screenshot 2024-09-23 at 3 28 16 pm

@aaronrobertshaw aaronrobertshaw merged commit 5284920 into trunk Sep 23, 2024
68 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/query-no-results-example branch September 23, 2024 06:22
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] No Results Affects the No Results Block - used when a Query Loop returns no results [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants