Add Editable placeholders #756
Conversation
|
|
||
| const content = this.getContent(); | ||
|
|
||
| this.setState( { |
There was a problem hiding this comment.
Probably shouldn't be calling this all the time.
There was a problem hiding this comment.
I'm not sure if this would trigger a re-render if the value is the same?
This performs a shallow merge of stateChange into the new state.
https://facebook.github.io/react/docs/react-component.html#setstate
I do notice a lot of re-renders form node change though, not from this one.
There was a problem hiding this comment.
I'm not sure if this would trigger a re-render if the value is the same?
Yes it does: https://codepen.io/aduth/pen/mmXgxQ
We'd need to expose and use React.PureComponent for it to not: https://facebook.github.io/react/docs/react-api.html#react.purecomponent
Alternatively just compare against state here and return; early if it would end up being the same.
ellatrix
added
the
[Feature] Rich Text
|
If it needs any changes, a new ticket can be opened. |
|
Thank you so much for working on this! I know it's been quite hellish — really appreciate you sticking with it! |
|
:) Yeah it wasn't really adding the placeholders specifically, should have just done it like this a while ago... Let's look at the rest separately. |
This is #475 but without any other improvements.