Inserter: Move the inserter at the bottom of the editor to the right #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Inserter
aduth
approved these changes
May 12, 2017
|
@jasmussen Any thoughts on the design here? |
|
Looks good! Perhaps when it's on the right, push it in another few pixels so the left edge of the inserter aligns with the left border of a highlighted block. It's a little tight on the edge at mobile responsive:
|
youknowriad
force-pushed
the
fix/left-align-inserter
branch
from
aec9273
to
94e2153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #775
This PR adds the position to position the inserter to the right (moving the inserter and the arrow), we could easily add the possibility to left align it as well.