-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address "wide" alignment programatically #812
Merged
Merged
Commits on Jun 7, 2017
-
Remove full-width trick pending better one
This also adds a few improvements from the now deleted branch, #799, notably: - clearing for video blocks. The responsive trickery means we have to, or we will get odd behavior otherwise - better collapsing margins fix for the toolbar.
Configuration menu - View commit details
-
Copy full SHA for 549228d - Browse repository at this point
Copy the full SHA 549228dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9968972 - Browse repository at this point
Copy the full SHA 9968972View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d68c23 - Browse repository at this point
Copy the full SHA 4d68c23View commit details -
Keep track of editor width values in redux state.
Update when sidebar is toggled.
Configuration menu - View commit details
-
Copy full SHA for e641ccb - Browse repository at this point
Copy the full SHA e641ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 274b0fa - Browse repository at this point
Copy the full SHA 274b0faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7325ba3 - Browse repository at this point
Copy the full SHA 7325ba3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 662aab6 - Browse repository at this point
Copy the full SHA 662aab6View commit details -
There were some issues with centering blocks, due to the fact that it has a block mover on the left. This commit simplifies that math, so the block mover doesn't actually affect the padding of the block, but rather uses negative space, making the math simpler. Additionally, it adds some responsive fixes for the full wide toolbar positioning.
Configuration menu - View commit details
-
Copy full SHA for 8f138a8 - Browse repository at this point
Copy the full SHA 8f138a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaeb881 - Browse repository at this point
Copy the full SHA aaeb881View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7888a8 - Browse repository at this point
Copy the full SHA b7888a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e999c9 - Browse repository at this point
Copy the full SHA 5e999c9View commit details -
Address responsive issues with emulated floats
We are emulating floats using margins. This works well enough, but has some responsive implications. This commit addresses those, by creating a mix-in that simplifies the breakpoints. I couldn't quite figure out where to best place this mixin, and we also probably want to extract both the mixin, the variables, and even the left/right alignment code so that other blocks that utilize these don't have to copy the whole bit of code. But I wanted to push this so we can test, and then discuss.
Configuration menu - View commit details
-
Copy full SHA for a4d712e - Browse repository at this point
Copy the full SHA a4d712eView commit details -
Clean up double semicolons, better center toolbars, remove border-box.
Configuration menu - View commit details
-
Copy full SHA for 3c883b7 - Browse repository at this point
Copy the full SHA 3c883b7View commit details
Commits on Jun 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9ea3743 - Browse repository at this point
Copy the full SHA 9ea3743View commit details -
Hide movers and fix sticky menu
This commit hides the movers on floated images. We can look at reintroducing them for floats and full width images in a separate PR. It also fixes another responsive issue where the sidebar is stickied.
Configuration menu - View commit details
-
Copy full SHA for 1923ade - Browse repository at this point
Copy the full SHA 1923adeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.