Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address "wide" alignment programatically #812

Merged
merged 15 commits into from
Jun 8, 2017
Merged

Address "wide" alignment programatically #812

merged 15 commits into from
Jun 8, 2017

Commits on Jun 7, 2017

  1. Remove full-width trick pending better one

    This also adds a few improvements from the now deleted branch, #799, notably:
    
    - clearing for video blocks. The responsive trickery means we have to, or we will get odd behavior otherwise
    - better collapsing margins fix for the toolbar.
    jasmussen authored and mtias committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    549228d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9968972 View commit details
    Browse the repository at this point in the history
  3. Polish the toolbar centering math.

    jasmussen authored and mtias committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    4d68c23 View commit details
    Browse the repository at this point in the history
  4. Keep track of editor width values in redux state.

    Update when sidebar is toggled.
    mtias committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    e641ccb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    274b0fa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7325ba3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    662aab6 View commit details
    Browse the repository at this point in the history
  8. Improve responsiveness.

    There were some issues with centering blocks, due to the fact that it has a block mover on the left.
    
    This commit simplifies that math, so the block mover doesn't actually affect the padding of the block, but rather uses negative space, making the math simpler.
    
    Additionally, it adds some responsive fixes for the full wide toolbar positioning.
    jasmussen authored and mtias committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    8f138a8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    aaeb881 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b7888a8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5e999c9 View commit details
    Browse the repository at this point in the history
  12. Address responsive issues with emulated floats

    We are emulating floats using margins. This works well enough, but has some responsive implications. This commit addresses those, by creating a mix-in that simplifies the breakpoints.
    
    I couldn't quite figure out where to best place this mixin, and we also probably want to extract both the mixin, the variables, and even the left/right alignment code so that other blocks that utilize these don't have to copy the whole bit of code. But I wanted to push this so we can test, and then discuss.
    jasmussen committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    a4d712e View commit details
    Browse the repository at this point in the history
  13. Address feedback.

    Clean up double semicolons, better center toolbars, remove border-box.
    jasmussen committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    3c883b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2017

  1. Configuration menu
    Copy the full SHA
    9ea3743 View commit details
    Browse the repository at this point in the history
  2. Hide movers and fix sticky menu

    This commit hides the movers on floated images. We can look at reintroducing them for floats and full width images in a separate PR.
    
    It also fixes another responsive issue where the sidebar is stickied.
    jasmussen committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    1923ade View commit details
    Browse the repository at this point in the history