Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cover image #879

Merged
merged 17 commits into from
Jun 22, 2017
Merged

Add cover image #879

merged 17 commits into from
Jun 22, 2017

Commits on Jun 22, 2017

  1. Cover Image is showing up in the editor… kinda…

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    6e045c7 View commit details
    Browse the repository at this point in the history

  2. background image not showing up

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    e54c0e7 View commit details
    Browse the repository at this point in the history

  3. Fixed background image style

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    c667218 View commit details
    Browse the repository at this point in the history

  4. Clean up and remove outdated code

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    14c006e View commit details
    Browse the repository at this point in the history

  5. Use MediaUploadButton

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    76d80ce View commit details
    Browse the repository at this point in the history

  6. Cover images working in the editor 

    Thanks to @mkaz for the pairing session to get it done
    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    a0ff9d7 View commit details
    Browse the repository at this point in the history

  7. registerBlock ➡️ registerBlockType

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    75964d8 View commit details
    Browse the repository at this point in the history

  8. Fix tests

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    e3c899b View commit details
    Browse the repository at this point in the history

  9. Remove formatting options for title

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    36a9f5e View commit details
    Browse the repository at this point in the history

  10. Add background-attachment: fixed view

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    dd241d9 View commit details
    Browse the repository at this point in the history

  11. Pre-selecting image by URL doesn't make sense

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    41f9966 View commit details
    Browse the repository at this point in the history

  12. Control updates 

    Now using the new `<BlockControls>` to manage the image position.

Also removed the ability to change the picture pending moving it into the inspector

Also addressed changes in the PR to remove `wp` global and fix autoOpen the MediaUploadButton
    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    bf18706 View commit details
    Browse the repository at this point in the history

  13. A little polish 

    - Make background attachment fixed by default. Let's either remove the option to pin it entirely, or move it to the inspector and make it something that's on by default.
- Added gray scrim, removed text shadow, reduced font size
- Removed alignments because these are now inherited

Future improvements we should also consider: add the full-wide button that images have now, and make it so the dark scrim is only present when there's text.
    @jasmussen
    jasmussen authored and George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    6985c7b View commit details
    Browse the repository at this point in the history

  14. Re-introduce post-content data

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    336b453 View commit details
    Browse the repository at this point in the history

  15. Add cover-image back into list

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    99fb455 View commit details
    Browse the repository at this point in the history

  16. Removing "fixed" alignment

    George Hotelling committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    bfcbe7d View commit details
    Browse the repository at this point in the history

  17. Fix full bleed issues.

    @jasmussen
    jasmussen committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    59f89b1 View commit details
    Browse the repository at this point in the history