Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qs dependency typo #9692

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Fix qs dependency typo #9692

merged 2 commits into from
Sep 7, 2018

Conversation

youknowriad
Copy link
Contributor

Related #8300 (comment)

@youknowriad youknowriad self-assigned this Sep 7, 2018
@@ -20576,7 +20576,7 @@
},
"chalk": {
"version": "1.1.3",
"resolved": "https://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz",
"resolved": "http://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the npm install changed this too

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we note this in CHANGELOG.md for a patch release of @wordpress/url ?

@youknowriad
Copy link
Contributor Author

@aduth I don't have the changelog habit yet :P

@youknowriad youknowriad merged commit c1cdd95 into master Sep 7, 2018
@youknowriad youknowriad deleted the fix/qs-dependency branch September 7, 2018 15:45
@mtias mtias added this to the 3.9 milestone Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants