Chrome: Adding the post external link component #971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I test? I'm not seeing any added UI. |
|
@iseulde did you save the post. (Sorry it's not clear, but yeah the link is showing only for saved posts) |
mtias
added
the
General Interface
|
@jasmussen What's the status for this, should we close for now? |
|
Let's keep it around, but unmerged. I still have a hunch we might need it, but it'd be good to blog with this thing for a bit to know for sure. Thanks for working on it. |
|
Closing as the issue was closed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #969
I'm using a "title" instead of a tooltip (There's a current PR for tooltips).