Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the mobile React Native testsuite with the main Gutenberg build #9883

Merged
merged 18 commits into from
Sep 18, 2018
Merged

Integrate the mobile React Native testsuite with the main Gutenberg build #9883

merged 18 commits into from
Sep 18, 2018

Commits on Sep 13, 2018

  1. Install Yarn as part of the local setup

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5cac2dc View commit details
    Browse the repository at this point in the history

  2. Add scripts to run the mobile testsuite 

    The mobile code is assumed to be in the `gutenberg-mobile` subfolder.
    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    05313b6 View commit details
    Browse the repository at this point in the history

  3. Add the native mobile app repo as a submodule

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    fe5a00a View commit details
    Browse the repository at this point in the history

  4. Run the mobile testsuite as Travis jobs

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    04c425a View commit details
    Browse the repository at this point in the history

  5. Ignore mobile subfolder when linting 

    The mobile project has its own lint rules and until the two projects can
work off the same rules the main Gutenberg project needs to ignore it.
    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    75fb748 View commit details
    Browse the repository at this point in the history

  6. Ignore the mobile subfolder to run Jest tests 

    The mobile project still has Gutenberg as its own git submodule and so,
many packages can be found in two places. Jest tests need to ignore the
occurance of this second gutenberg sourcetree instance.
    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    398a414 View commit details
    Browse the repository at this point in the history

  7. yarn install shouldn't be ran as part of the test script 

    Instead, run `yarn install` earlier or in the same manner as `npm install`.
    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5ba0b20 View commit details
    Browse the repository at this point in the history

  8. Run the mobile testsuite as part of the test script

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    6db3b9c View commit details
    Browse the repository at this point in the history

  9. yarn install inside mobile when in Travis

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    88c641d View commit details
    Browse the repository at this point in the history

  10. Ignore the mobile subfolder to run e2e Jest tests

    @hypest
    hypest committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    91165d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Add some use and debugging instructions for mobile tests

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    fecffe2 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    60a4935 View commit details
    Browse the repository at this point in the history

  3. Yarn as a dev dep and auto fetch and install mobile code 

    * Yarn is installed locally as a development dependency
* The mobile submodule is updated in preinstall
* The mobile packages are installed in preinstall as well
* Yarn is executed by providing the working (sub)directory as a
parameter
* No need to install yarn globally in Travis
    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    5eaf120 View commit details
    Browse the repository at this point in the history

  4. No need for npx. yarn is available to npm in scripts

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    551292a View commit details
    Browse the repository at this point in the history

  5. No need for npx in postinstall either

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    924ced2 View commit details
    Browse the repository at this point in the history

  6. Fix copy&paster error. Only update submodule in preinstall

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    5429e1c View commit details
    Browse the repository at this point in the history

  7. Run the mobile tests in parallel for the test script

    @hypest
    hypest committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    0c5da64 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Add the mobile submodule to coverage ignore patterns

    @hypest
    hypest committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    24cd903 View commit details
    Browse the repository at this point in the history