add wp-hooks, first pass

updates from ticket, flesh out removeAll, cleanup

inline docs cleanup

remove some commented code

downgrade initial version

clean up imports for (empty) tests file

bring over object approach from core instead of passing around string

First pass, jest tests

add remainder of tests

Docs refinements

Break out code into one file per funciton

Centralize all run logic into createRunHook …

Also fixes a bug that `doingAction` would remain true after its action
was completed.  Effectively it would always be true.

nylen committed Jul 20, 2017

Use a consistent order for functions

nylen committed Jul 20, 2017

Merge branch 'add-wp-hooks' of github.com:adamsilverstein/packages in… …

…to add-wp-hooks

Fix currentFilter and unit-test it

nylen committed Jul 20, 2017

Add currentAction and unit-test it

nylen committed Jul 20, 2017

Declare base hooks objects as objects, not arrays

nylen committed Jul 20, 2017

Merge branch 'add-wp-hooks' of github.com:adamsilverstein/packages in… …

…to add-wp-hooks

Several fixes to hook removal behavior …

- Calling `removeAction` and `removeFilter` without a callback should
  not remove all hooks.  This operation should be explicitly requested.
- Calling `removeAllActions` and `removeAllFilters` should not reset
  `didAction` and `didFilter` counts.

Also correctly reset state (clear all hooks and all hook call counts)
before each test.

nylen committed Jul 20, 2017

Fix hasAction and hasFilter if all hooks have been removed

nylen committed Jul 20, 2017

Remove now-unused createRemoveAllHook

nylen committed Jul 20, 2017

Naming and documentation cleanup …

- `hooks`: A hooks object, keyed by hook name
- `hookName`: A hook name
- `handlers`: The handlers for a single hook
- All top-level and inner (returned) functions have names.

nylen committed Jul 20, 2017

Make hasAction and hasFilter return the number of registered hooks …

This is different than PHP, because the existing PHP API that these
functions accept a callback and return its priority won't work well in
JavaScript.  Instead, when we implement namespaced hooks, these
functions should work the same way:  return the number of handlers
registered under the given hook and namespace.

nylen committed Jul 20, 2017

Remove unnecessary describe/it pairs …

Just replace them with `test` instead, per the Jest examples.

nylen committed Jul 20, 2017

A bit more function declaration cleanup

nylen committed Jul 20, 2017

Use ES6 object shorthand

nylen committed Jul 20, 2017

Add explicit error reporting

nylen committed Jul 20, 2017

Test adding and removing multiple filters at the same priority

nylen committed Jul 20, 2017

Keep the hooks list always sorted instead of explicitly sorting it

nylen committed Jul 20, 2017

Remove remaining var statements

nylen committed Jul 20, 2017

Remove remaining per-test cleanup logic …

This is all handled in `beforeEach` now.

nylen committed Jul 20, 2017

Merge branch 'add-wp-hooks' of github.com:adamsilverstein/packages in… …

…to add-wp-hooks

Add webpack and build wp-hooks for core

remove built file and adjust build path

Remove unused dependencies

nylen committed Jul 20, 2017

Use an ES6 default argument to set the default hook priority

nylen committed Jul 20, 2017

Refactor handlers objects: don't assign extra properties on arrays

nylen committed Jul 20, 2017

Merge branch 'add-wp-hooks' of github.com:adamsilverstein/packages in… …

…to add-wp-hooks

Run core build JS thru babel

remove babel-loader for now

rename ‘current’ => ‘__current’ and make it a stack

Add initial readme based on https://github.com/adamsilverstein/WP-JS-… …

…Hooks

test remove a filter callback of lower priority when running hook

test remove a filter callback of same priority when running hook

prevent and test for (dingle level) hook recursion

test remove a filter callback of higher priority when running hook

Failing recursive test: remove one hook in a callback before adding a… …

…nother

Add babel-loader for core build

Merge remote-tracking branch 'origin/master' into add-wp-hooks

nylen committed Jul 24, 2017

Clean up tests for removing a filter while filters are running

nylen committed Jul 24, 2017

Add test demonstrating desired recursion behavior

nylen committed Jul 24, 2017

Convert most functions in tests to arrow functions (for consistency)

nylen committed Jul 24, 2017

Add failing test for currentFilter with multiple filters running

nylen committed Jul 24, 2017

Fix currentFilter behavior

nylen committed Jul 24, 2017

Add more currentFilter test assertions

nylen committed Jul 24, 2017

Remove wp-hooks.js entry point …

This logic needs to be generated by Webpack instead.  Otherwise
something like it will end up being duplicated and manually maintained
for every module in this repo.

nylen committed Jul 24, 2017

Merge remote-tracking branch 'origin/master' into add-wp-hooks

nylen committed Jul 24, 2017

Prevent hook names from starting with __ …

This would break some of the library's internal functionality.

nylen committed Jul 24, 2017

Prevent running hooks with invalid names

nylen committed Jul 24, 2017

Add missing tests for error conditions

nylen committed Jul 24, 2017

Make hook removal functions return the number of hooks removed

nylen committed Jul 24, 2017

Ensure that hook callbacks to remove are functions …

This will need to change later, but for now we should still make sure we
validate our expected inputs strictly.

nylen committed Jul 24, 2017

Test running a filter with no callbacks

nylen committed Jul 24, 2017

doAction should return undefined

nylen committed Jul 24, 2017

Add failing test for recursive filters

nylen committed Jul 24, 2017

First attempt at handling adding/removing callbacks during execution …

Also allows recursion.

nylen committed Jul 24, 2017

Make the filter adding/removing/recursion test pass

nylen committed Jul 24, 2017

Minor style and speed improvement

nylen committed Jul 24, 2017

Add missing tests

nylen committed Jul 24, 2017

Merge branch 'add-wp-hooks' of github.com:adamsilverstein/packages in… …

…to add-wp-hooks

Add a centralized webpack folder based build for packages

Add check: the hook name can only contain numbers, letters and unders… …

…cores

use yoda conditional as per wp coding standards

removeHook - accept a namespace parameter and use it to identify item… …

… for removal

addHook - The hook name can only contain numbers, letters and undersc… …

…ores

addHook - accept a namespace parameter and store in handler data

Use some Yoda conditionals

Ensure the passed namespace is a string of the form `my-plugin-slug/f… …

…unctionDescription

Add a build-modules command to run webpack

Add a validateNamespace helper, centralizing namespace checks

Add a validateHookName helper, centralizing hookName validation

Use new hookName and namespace validation helpers throughout generato… …

…rs for each hookName/namespace use

Update tests to use namespaces

Update readme with new hook/namespace signature

Improve validateNamespace and validateHookName inline docs

require a non-empty string when validating namespace/hookName

Adjust expected error language in tests.

Improved regexes for hookName and namespace validation

Add more tests around hookName and namespace validation

Validate namespace takes form vendorName/pluginName/functionName

Update tests with new namespace format

update readme with new namespace format

remove module build from branch

Correct namespace strings in docblocks

Add args to applyFilters docs in readme

camelCase for readme variable names

update hook and vendor/plugin/function wording, removing Name

complte namespace shortening to vendor/plugin/function