This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Hooks: Update hooks public API to make it possible to apply to wp.hooks
directly
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed in during the last Core JS meeting. See: https://wordpress.slack.com/archives/C5UNMSU4R/p1511276154000233.
The idea here is to have
@wordpress/hooks
===wp.hooks
, so we could use it directly in Gutenberg. It was raised while working on hooks integration with Gutenberg: WordPress/gutenberg#3493. The existing implementation created an ambiguity where we weren't able to easily expose hooks aswp.hooks
and import using@wordpress/hooks
at the same time. This PR opens this possibility by making import statement for@wordpress/hooks
identical to what is going to be exposed aswp.hooks
: