Create the vertical header template part and adjust headings #381
+45
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the vertical header template part, and use it in the templates for the design with the vertical header and right aligned blog. Ensure the design has a single H1 heading.
Description
This PR replaces #285,
and the only reason for this is to avoid the merge conflict so that the changes can be merged right away.
I also added the new hidden-blog-heading pattern as a replacement for the plain text heading.
Previous description:
Regarding Issue #279 - the vertical header was outsourced to a template part and registered in the theme.json.
The pattern for the vertical header was inserted and the title was changed to level 0.
The new template part was inserted at all places where the original vertical header was used.
Also all there is now only one h1 on every template. But for the home template "vertical-header-aligned-home-template.php" I have added a h1 with "Blog" like the original home.html - because the blog posting shouldn't be the h1 and there was no other good option to set the h1.
In the archive it's the archive title, on the single pages and posts its the title and in the search results its the query title.
There shouldn't be visible changes as I tested, except the "Blog" title in the home-template.php