Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the vertical header template part and adjust headings #381

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

carolinan
Copy link
Contributor

Create the vertical header template part, and use it in the templates for the design with the vertical header and right aligned blog. Ensure the design has a single H1 heading.

Description
This PR replaces #285,
and the only reason for this is to avoid the merge conflict so that the changes can be merged right away.

I also added the new hidden-blog-heading pattern as a replacement for the plain text heading.

Previous description:

Regarding Issue #279 - the vertical header was outsourced to a template part and registered in the theme.json.
The pattern for the vertical header was inserted and the title was changed to level 0.

The new template part was inserted at all places where the original vertical header was used.
Also all there is now only one h1 on every template. But for the home template "vertical-header-aligned-home-template.php" I have added a h1 with "Blog" like the original home.html - because the blog posting shouldn't be the h1 and there was no other good option to set the h1.
In the archive it's the archive title, on the single pages and posts its the title and in the search results its the query title.

There shouldn't be visible changes as I tested, except the "Blog" title in the home-template.php

Create the vertical header template part, and use it in the templates for the design with the vertical header and right aligned blog.
Ensure the design has a single H1 heading.
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review September 21, 2024 05:09
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan merged commit 696ed54 into trunk Sep 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant