Font Face: Fix getting the font-family name #5298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a BC break in how the font-family name is pulled from the incoming font data.
Merge from Gutenberg's PR WordPress/gutenberg#54615.
What?
Gets the font-family name from the
"fontFamily"field, instead of the"name"field.Why?
To avoid a back-compatibility (BC) break for themes that do not have the
"name"field defined.WP Core also does not require the
"name"setting. Using it exclusively is a BC break.It's not clearly documented that the
"name"setting is required. Thus, it's been optional.How?
Uses the font-family's
fontFamilyfield instead of itsnamefield.As the
fontFamilyfield could be a comma-separated list of font-families, it parses the list to extract the first entry.Why
fontFamilysetting?WP_Theme_JSONschema requires thefontFamilysetting in each of thetypography.fontFamilies.Trac ticket: https://core.trac.wordpress.org/ticket/59165
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.