Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport theme.json tests from Gutenberg #5979

Closed
wants to merge 15 commits into from

Conversation

ajlende
Copy link

@ajlende ajlende commented Jan 30, 2024

Merges the changes from Core and Gutenberg for the following tests:

  1. WP_REST_Global_Styles_Controller_Test
  2. Tests_Theme_wpThemeJsonResolver
  3. Tests_Theme_wpThemeJsonSchema
  4. Tests_Theme_wpThemeJson

Paired with WordPress/gutenberg#58476.

Trac ticket: https://core.trac.wordpress.org/ticket/60387


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ajlende ajlende force-pushed the backport/global-styles-tests branch from c7e0cd5 to c1eb493 Compare February 1, 2024 01:39
@ajlende ajlende marked this pull request as ready for review February 1, 2024 02:51
Copy link

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I think there's still more things we can do to make them more aligned, but this is a step in the right direction.

@getdave
Copy link

getdave commented Feb 2, 2024

@youknowriad this has a ✅

Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ajlende, scruffian, aaronrobertshaw, get_dave, youknowriad.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad
Copy link
Contributor

Can we get this rebased please. Thank you.

@scruffian
Copy link

It would be great if we can bring this in to trunk so we can keep things synced up

@youknowriad
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants