Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Forward ref to Select input #2892

Merged

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Aug 26, 2024

Summary

Adds back ref forwarding to the <Select> component. The ref is the hidden server input with focus and blur methods redirecting to the visual input.

Fixes: #2887

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4 mannycarrera4 marked this pull request as draft August 26, 2024 22:22
@mannycarrera4 mannycarrera4 marked this pull request as ready for review August 27, 2024 16:09
@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Aug 27, 2024
@NicholasBoll NicholasBoll changed the title fix: Forward ref to Select input to allow focusing via ref fix(select): Forward ref to Select input Aug 27, 2024
@NicholasBoll NicholasBoll added automerge and removed ready for review Code is ready for review labels Aug 27, 2024
@alanbsmith alanbsmith enabled auto-merge (squash) August 27, 2024 16:33
@alanbsmith alanbsmith enabled auto-merge (squash) August 27, 2024 16:33
@alanbsmith alanbsmith enabled auto-merge (squash) August 27, 2024 16:45
@alanbsmith alanbsmith merged commit b511c7f into Workday:support Aug 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants