chore: Merge prerelease/minor into prerelease/major #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #701 Set `role`, `aria-label`, and `aria-selected` to provide better accessibility when user is interacting with color swatches [category:Accessibility] Co-authored-by: Kiwook Kwon <kiwook.kwon@workday.com>
#2906) Fixes: #2905 This fixes a TS error in buttons that wouldn't allow the update of the focusRing styles through the colors prop. Also, deprecated the use of focusRing within focus in the colors prop on buttons and added support for boxShadowInner and boxShadowOuter within focus in colors prop. [category:Components] Release Note: Deprecated the use of focusRing within focus in the colors prop on buttons as this does not work with our current styling methods. Added support for boxShadowInner and boxShadowOuter within focus in colors prop.
Co-authored-by: @josh-bagwell <44883293+josh-bagwell@users.noreply.github.com> Co-authored-by: @NicholasBoll <nicholas.boll@gmail.com>
mannycarrera4
approved these changes
Sep 10, 2024
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
merge/prerelease/minor-into-prerelease/major
|
| Run status |
|
| Run duration | 03m 22s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
14
|
Pending
|
16
|
Skipped
|
0
|
Passing
|
854
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.18%
|
|
|---|---|
|
Untested elements
|
1818
|
|
Tested elements
|
486
|
Accessibility
99.18%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
228
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:
The pull request should inform you of merge conflicts before you start if any.
If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the
mergestrategy instead of thesquashstrategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:You must then force-push the branch and the CI will rerun verification.
Use the
automergelabel like normal and the CI will pick the correct merge strategy.