CP-1099 Add close() to client. Add integration tests.

[evanweible-wf]

Issue

• No way to close the SockJS client.
• No tests.

Changes

Source:

• Add a close([int code, String reason]) method to Client.
  • Calls .close() on the underlying WebSocket instance if websocket protocol is being used
  • Calls ._didClose() on the Client if xhr-streaming protocol is being used

Tests:

• Integration tests added for..
  • default configuration (no protocol whitelist specified)
  • websocket protocol
  • xhr-streaming protocol

Areas of Regression

• closing of underlying transport

Testing

• pub get && pub run dart_dev test

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

fyi: @bryonmarks-wf @thieupham-wf @katiesullivan-wf

[rmconsole-wf]

General Information

Ticket(s): CP-1099
Code Review(s): #3
CI:
Automation: Could not find automation run associated with this pull.

SOC 1 Checklist

• All commits reviewed
• QA Review
• Security review completed for all commits if applicable: (N/A)

RM Checklist

• Ticket(s) Verified
• Smithy build successful (no build info found)
• Smithy run in past 24 hours (no build info found)
• Smithy run against most recent commit (no build info found)
• Total danger score is less than 500 and each file has danger score less than 100
• Unit Tests Updated
  • Tests updated for .dart code changes
  • Tests updated for .js code changes

Additional Information

Reviewers: trentgrover-wf, jayudey-wf, maxwellpeterson-wf
Watchlist Notifications: None

Automatically Identified Dependencies: smithy not yet complete

    When this pull is merged I will use the following information:
    Version: sockjs-dart-client 1.0.0
    Release Ticket(s): CP-1096

---

Last updated on Wednesday, November 11 04:16 PM CST

[maxwellpeterson-wf]

+1

[trentgrover-wf]

+1

[trentgrover-wf]

@jayudey-wf ready for merge

[jayudey-wf]

QA Resource Approval: +10

• Testing instruction
• Dev +1's
• Dev/QA +10 with detail of what was tested
  • tests pass as expected with pub run dart_dev test --integration
• Unit test created/updated
• All unit tests pass

Merging into master.