Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker environment to Ubuntu 22, Python 3.10 #824

Merged

Conversation

fpjentzsch
Copy link
Collaborator

@fpjentzsch fpjentzsch commented May 25, 2023

Updates the base Docker image to Ubuntu 22.04, where Python 3.10 is the default. Some dependencies are updated alongside.

Fixes #766.

Tested so far:

  • Quicktest
  • Full test suite
  • Cybsec notebooks
  • Other notebooks
  • CUDA support (FINN_DOCKER_GPU=1)
  • Full Zynq build
  • Full Alveo build
  • Vitis/Vivado 2022.2
  • Vitis/Vivado 2023.1
  • Linting

Issues:

  • pip install --user--editable is broken for certain packages (here: qonnx)
  • Xilinx tools crash during synthesis due to FlexLM issue
  • The update from PyTorch 1.7/ONNX v6/ai.onnx v9 to PyTorch 1.13.1/ONNX v7/ai.onnx v14 causes different finn-onnx export behavior in Brevitas (tested 0.8.0 and 0.9.1):
    • Primary input tensor name is not always "0", this was previously assumed
      • -> Workaround by providing "input_names" explicitly to export function
    • In certain cases the exported graph will no longer exhibit unique parameter tensors
      • -> Workaround by calling GiveUniqueParameterTensors()
  • Linting: as of now, the following reformattings would take place:
    • Minor automatic changes (e.g., addition/removal of empty lines) to 22 files
    • Line length limit (currently 88 characters) was previously not always enforced for multi-line strings ("""). After this update, a few occurences are slightly over the limit (13 lines in 11 files)

Depends on:

@auphelia auphelia changed the base branch from dev to feature/2023_1 May 30, 2023 14:49
@fpjentzsch fpjentzsch marked this pull request as ready for review June 1, 2023 11:53
@fpjentzsch
Copy link
Collaborator Author

Combining this with the update to 2023.1 tools by merging into feature/2023_1. Some issues, such as updating qonnx and fixing the linting, remain and will be fixed in that branch before merging to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants