Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: queue store #36

Merged

Conversation

Pantotone
Copy link
Member

@Pantotone Pantotone commented Dec 26, 2023

Tried to simplify the queue store and remove the need for one more provider (as we're using Zustand, we don't need it)

image

TO-DO:

  • create useCurrentTask()
  • reimplement dialog error message
  • remove first item from queue list on queue page as now we don't use a separate store for current task
  • investigate why the setlist download button glitches sometimes

@EliteAsian123
Copy link
Member

Thanks for the PR! I'll tackle fixing number 4 right now, I'll just push it onto your branch.

@Pantotone Pantotone marked this pull request as ready for review December 30, 2023 10:02
@EliteAsian123
Copy link
Member

Whoops, didn't see this was done. Good work! Thanks so much!

@EliteAsian123 EliteAsian123 merged commit 296134e into YARC-Official:new-backend Jan 1, 2024
1 check passed
EliteAsian123 added a commit that referenced this pull request Jan 1, 2024
* Started new launcher backend

* Did a bunch of refactoring for YARG

* More backend stuff

* Added launch code back

* Reimplemented invokes in the TypeScript side

* Implement "uninstall" functions

* Readd dropdown again lol

* Simplified awaits and asyncs

* Removed linux permission setting in install as the zip extractor already does it

* Moved `.../utils/Download` to `.../tasks`

* Renamed "download" declarations to "task"

* Some progress on rewriting the typescript side of things

* Forgot the return

* refactor: queue store (#36)

* refactor: queue store

* Fixed potential error

* Refactored setlist releases to be more similar to YARG releases

* feat: useCurrentTask

* Fixed setlist button dropdown sizing

* refactor: dialogs

* chore: remove first item on queue list when downloading

---------

Co-authored-by: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>

* Made the uninstall button work!

---------

Co-authored-by: Pantotone <guustavopantoja@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants