Added support for more characters in the lyric tracks #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses '§' in the midi track to '‿'
This allow for accented characters in lyric tracks (changed from just ASCII)
This font didn't have the undertie (U+203F) glyph in it so I slapped in both and had to regenerate the font atlases. Taken from Gnu's freefont.
Purplo-cf
pushed a commit
to Purplo-cf/YARG
that referenced
this pull request
May 14, 2024
* Rename _position to _tickPosition * Make YARGMidiTrack responsible for its own data * Implement VLQ absorption as alternative to full parsing Scanning does not use any of the actual positional information, so not having to parse it could provide a benefit * Re-add MemoryStream special case for MidiTrack * Remove need for SkipEvent() * Minor alteration to Non-Meta event handling * Rename memory variable * Use constant max vs iterative for loop in AbsorbVLQ conditional * VLQ magic number removal * Use switch over list of if-elses for event parsing * Remove unnecessary byte[] variable * Account for SequenceNumber event type in process loop * Midi constant adjustments + Use hex representation for bitwise values. + Add summary comment describing VLQ_SHIFTLIMIT's functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for accents and other extended characters as well as the undertie